Remove WC v1 - Githubissues

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket

https://rainbow.me

GNU General Public License v3.0

3.96k stars 628 forks source link

Remove WC v1 #6214

Closed jinchung closed 1 month ago

jinchung commented 1 month ago

Fixes APP-1585

What changed (plus any additional context for devs)

Remove WalletConnect v1 (redux/walletconnect as well as entrypoints using WC v1)
Remove requests redux (redux/requests) which was being used by both WC v1 and v2 and replace it with a new store (state/walletConnectRequests)
Removed localstorage for WC requests
We are choosing to ignore migration from redux/localstorage to the new store
Follow up ticket created: alerting the user if they are using a WC v1 request

Screen recordings / screenshots

https://github.com/user-attachments/assets/44d1e2ed-384a-448e-9aca-d48686505444

What to test

Test WC flows (message signing, transactions, connections) that they work as expected
Test that requests still show up in the transaction list as expected and behave as expected when you interact with them

linear[bot] commented 1 month ago

APP-1585 Rip out walletconnect v1