Consolidate env prod vs dev keys usage

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket

https://rainbow.me

GNU General Public License v3.0

3.96k stars 628 forks source link

Consolidate env prod vs dev keys usage #6255

Open jinchung opened 2 weeks ago

jinchung commented 2 weeks ago

Related to APP-2008

What changed (plus any additional context for devs)

Cleans up more unused configs
Consolidates some keys that are prod vs staging (will create a separate followup PR for creating separate staging vs prod configs.)
Associated with: https://github.com/rainbow-me/rainbow-env/pull/73

Screen recordings / screenshots

What to test

wallet data still behaves as expected
NFT related data (mints, offers, nft metadata) looks the same

linear[bot] commented 2 weeks ago

APP-2008 Consolidate prod vs dev keys

brunobar79 commented 2 weeks ago

Launch in simulator or device for 74e7f592171d8ceadaf551b084b02fbd25d85c34

jinchung commented 2 weeks ago

LGTM. One question: Why do we alias some env vars inside env.ts and not some others? One example in this PR is RESERVOIR_API_KEY

I think it started off with the IS_PROD vs not and some were added there in order to distinguish between PROD vs STAGING envs and expose them. Now that we don't need to do that for the RESERVOIR key, I'll follow up in another cleanup PR and remove the instances that use the env.ts for it.

brunobar79 commented 2 weeks ago

Launch in simulator or device for 3da66cc42968572553f70f8332a58092b00e2a80