rainbow-me / rainbowkit

The best way to connect a wallet 🌈 🧰
https://rainbowkit.com
MIT License
2.33k stars 587 forks source link

[bug] Can't connect Rainbow or CB mobile wallets using RainbowKit QR codes #1979

Open arsena21 opened 2 weeks ago

arsena21 commented 2 weeks ago

Is there an existing issue for this?

RainbowKit Version

whatever is on https://www.rainbowkit.com/

wagmi Version

whatever is on https://www.rainbowkit.com/

Current Behavior

(note: we are seeing this on our own app, and is reproducible on https://www.rainbowkit.com/, so we are explanining what we see on rainbowkit.com for ease)

When I'm on rainbowkit.com on desktop, and click Connect wallet in the top right, I get a popup. If I then click on Rainbow, or Coinbase Wallet, I get a QR code.

Whether I scan that QR code in the native mobile apps, or I scan the QR code on the phone camera, nothing happens.

I am able to connect to Rainbow wallet via WalletConnect at least. The same can not be said about Coinbase wallet. I am on the latest version of the Rainbow mobile app as well as the Coinbase app. I am using an iphone. This has been tested on Chrome and Firefox on desktop, and I am on a Mac.

Expected Behavior

Should be able to connect to mobile apps via QR codes.

Steps To Reproduce

No response

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

magiziz commented 2 weeks ago

@arsena21 I can reproduce this with both wallets. I'll debug and see what's going on here, but thank you for pointing this out 👍

grantatrainbowdotme commented 2 weeks ago

Hey! Something I've noticed with our latest QR updates in Rainbow mobile apps is the QRs scan best when they fill the scanner outline between 25-50% full. This allows you to scan the QRs from much further away than you used to be able to.

The old version of our QR scanner only worked when filling the scanner outline ~100%. But the new one doesn't work unless you hold your phone a little further away.

arsena21 commented 2 weeks ago

Ah... this did the trick, I think. Need to so some more testing, but on first look, I think it solved it