search

rainbow-me / rainbowkit

The best way to connect a wallet 🌈 🧰
https://rainbowkit.com
MIT License
2.45k stars 673 forks source link

[bug] SafeWallet doesn't appear in list of wallet in RainbowKit modal #2197

Closed makiBaraba closed 2 months ago

makiBaraba commented 2 months ago

Is there an existing issue for this?

RainbowKit Version

2.0.0

wagmi Version

2.11.2

Current Behavior

When I add safeWallet to the rest of the rainbowkit config. Safe wallet connection is not appearing on RainbowKit modal. Also, when I try to open it inside iframe on safe wallet site, also doesn't work.

Safe wallet has an option, that you can open app like "Custom app", when I paste the link of my dapp, there is message "The app doesn't support Safe App functionality".

Expected Behavior

Expected behavior is that, it should work according the guide you have on your official docs.

Steps To Reproduce

  1. Added safeWallet to many wallets which are working just fine
  2. https://app.safe.global/ going to this website
  3. On section Apps -> Custom apps
  4. In the modal, in input field "Safe app url", entering the build of my app, I got error "The app doesn't support Safe App functionality"

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

DanielSinclair commented 2 months ago

I believe the issue is that you haven't included a Manifest file, which Safe requires to load the dApp on their end. Reference Safe's docs here and our example manifest here