search

raineaeternal / Quest-SongCore

A library/mod for Quest Beat Saber that handles song loading, song requirements and capabilities.
MIT License
5 stars 5 forks source link

Removed legacy BPM events support #35

Closed NSGolova closed 4 months ago

NSGolova commented 4 months ago

Port of: https://github.com/Kylemc1413/SongCore/pull/149

Event with a type 10 was introduced as an official BPM change event in 1.8.0 and later reused as a light in 1.18.0. This change disables the conversion of legacy BPM changes to add support for maps with type 10 events as lights, but with a wrong map version.

From the collection of 170k recently (last 2 years) played maps, there were 226 broken maps because of the conversion. Some are quite popular, and 2 ranked maps (1 on BL and 1 on SS). And not a single map that properly utilized these events as BPM changes. Popular mapping tools (MM/custom saber/CM) never had support for this event, and mappers who tried to use them manually were complaining, so I couldn't even find an example map, let alone a map anyone plays.

Tested on: https://beatsaver.com/maps/2b629

NSGolova commented 4 months ago

Do you mean the placeholderType? I can't really come up with anything better, it's just a placeholder