search

raineorshine / npm-check-updates

Find newer versions of package dependencies than what your package.json allows
Other
9.33k stars 323 forks source link

[Windows] CLI doesn't work if directory contains `node.js` file #1425

Open sqal opened 2 months ago

sqal commented 2 months ago

Steps to Reproduce

  1. Create package.json
{
  "name": "test-project",
  "version": "1.0.0",
  "private": true,
  "devDependencies": {
    "typescript": "^5.4.4"
  }
}

  1. 🚨 Create empty node.js file in the same directory as package.json

  2. Run ncu (should be globally installed)

Current Behavior

CLI doesn't work as expected. instead it opens the node.js file in my default editor, I see weird logs and the process hangs indefinitely

C:\Users\...>
[main 2024-06-12T12:44:11.859Z] update#setState idle
[main 2024-06-12T12:44:41.872Z] update#setState checking for updates
[main 2024-06-12T12:44:41.922Z] update#setState idle

Expected Behavior

CLI should work.

System Info

  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 20.14.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 4.1.1 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.5.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.2.0 - C:\Program Files\nodejs\pnpm.CMD
    bun: 1.1.11 - ~\.bun\bin\bun.EXE

  ncu version: 16.14.20

I also tested in on macOS, but I couldn't reproduce it on this os, only on Windows

// Edit: Ok, so the logs seems to come from vscode (since it's my editor), but I still can't figure out why the CLI doesn't work

raineorshine commented 2 months ago

Hi, thanks for reporting.

I'm not on Windows, but hopefully someone who is can reproduce the issue and offer a solution.