Improve Visual Studio detection

rainers / cv2pdb

converter of DMD CodeView/DWARF debug information to PDB files

Artistic License 2.0

472 stars 109 forks source link

Improve Visual Studio detection #38

Closed akihikodaki closed 5 years ago

akihikodaki commented 5 years ago

The new COM API is expected to work on Visual Studio 2017 and newer installations.

Actually the old detection code did not work for me; I didn't have the registry entry it looks for. The COM API works neatly. It is also used by vswhere, Microsoft's official detection tool, and reliable. It even says it can detect future versions.

akihikodaki commented 5 years ago

2e9c38671226de4f3601d2a59470cd1250aa2600 addresses https://github.com/rainers/cv2pdb/pull/38#discussion_r220687521.

akihikodaki commented 5 years ago

5e1632e2cca5b8d537bc66525d631ebd72f6949b also notes about non-x86 environment pointed out in https://github.com/rainers/cv2pdb/pull/38#pullrequestreview-159152569.

rainers commented 5 years ago

Thank you for your contribution. I've added the package contents and made some minor adjustments: https://github.com/rainers/cv2pdb/commit/58dab3c4102e99a9444dcf5e445f2e3fd9cdb5ec