rainers / cv2pdb

converter of DMD CodeView/DWARF debug information to PDB files
Artistic License 2.0
466 stars 110 forks source link

Hang when vswhere produces no output #72

Closed LordAro closed 2 years ago

LordAro commented 2 years ago

I'm not entirely sure how, but I've ended up with the situation where I have vswhere.exe, but no actual Visual Studio install (Just MSBuild/build tools, i think?)

Obviously I'm in the wrong for not having a working VS install, but I don't think the tool should hang either :)

As best as I can tell, it's hanging on the ReadFile at:

https://github.com/rainers/cv2pdb/blob/c99df6c1597de7cfb174ab05beb3949a63a4b8c9/src/mspdb.cpp#L204-L210

due to read being a pipe, and vswhere producing no output?

image

Procmon shows that's what it did last before hanging forever, at any rate (it was still running when this screenshot was taken):

image

rainers commented 2 years ago

Fixed in https://github.com/rainers/cv2pdb/releases/tag/v0.51