search

rainers / cv2pdb

converter of DMD CodeView/DWARF debug information to PDB files
Artistic License 2.0
466 stars 110 forks source link

NASM bug #92

Open FunkyFr3sh opened 4 months ago

FunkyFr3sh commented 4 months ago

When one of the source files is built via NASM cv2pdb fails to remove the COFF_SYMBOLS from the built executable.

I tried to create a minimal version to reproduce the bug, it should build fine with w64devkit: nasm.zip no-nasm.zip

test exe (before cv2pdb): test1.exe.zip

Without NASM source file Before cv2pdb: image

After cv2pdb: image

With NASM source file Before cv2pdb: image

After cv2pdb: image

FunkyFr3sh commented 4 months ago

Actually, this bug is not related to NASM at all. It's related to the .patch section that is being added. Luckily in this case the section is only a temporary one and can be removed via objcopy .

Not sure if any changes are needed to cv2pdb to maybe improve the compatibility with such corner cases? I'll keep the issue open for now though. For me the problem is solved, feel free to close the issue if needed