rainestorme / murkmod

A continuation of fakemurk and mush that includes a plugin manager and additional useful utilities.
MIT License
21 stars 15 forks source link

Murkmod Helper extension "Manifest version 2 is deprecated" #97

Open Eboi47 opened 3 weeks ago

Eboi47 commented 3 weeks ago

Describe the bug The murkmod helper extension will say mush is not ready yet if you try to use anything. The mush terminal is still functional. I believe it is tied to the error which appears when viewing the extension page.

To Reproduce Steps to reproduce the behavior:

  1. Install the murkmod helper extension
  2. Click on the puzzle piece, and then the murkmod helper extension
  3. Click any button
  4. See error

Expected behavior The button would be pressed and the task would be successfully executed.

Screenshots Screenshot 2024-10-17 10 31 17 AM Screenshot 2024-10-17 10 25 17 AM

System (please complete the following information):

Additional context When viewing the extension in the chrome web store, it shows up as the deprecated Secure Shell extension. The non-deprecated version is here

CaenJones commented 2 weeks ago

As of this summer Google has switched to manifestV3 and has depreciated the manifestv2 standard. Because the manifest file has not been updated, the extension will not work.

https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline

rainestorme commented 2 weeks ago

As of this summer Google has switched to manifestV3 and has depreciated the manifestv2 standard. Because the manifest file has not been updated, the extension will not work.

https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline

Yep, that makes sense. The trick that allows the helper extension to work is that the keys are exposed in the ChromiumOS source tree... is there an alternative in newer versions for MV3?

Eboi47 commented 2 weeks ago

As of this summer Google has switched to manifestV3 and has depreciated the manifestv2 standard. Because the manifest file has not been updated, the extension will not work. https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline

Yep, that makes sense. The trick that allows the helper extension to work is that the keys are exposed in the ChromiumOS source tree... is there an alternative in newer versions for MV3?

When I go to the extension page on the chrome web store, it tells you to use this version. fixing this would also likely fix #77

rainestorme commented 2 weeks ago

You can see a list of the keys for extensions pretty easily in codesearch here - I'm sure at least one of these extensions would work - or maybe the current extension can just be updated straight to MV3? Who knows, this would need testing, and I don't have any testing devices on-hand right now.