raineszm / rubypython

Rubypython is no longer being maintained. Apologies for any inconvenience this might cause.
Other
9 stars 9 forks source link

Various fixes (ruby 1.9 and bundler) and internals #4

Closed dblommesteijn closed 5 years ago

dblommesteijn commented 11 years ago

Fixed support for Ruby 1.9, gemspec. Extracted VERSION to a separate file, and changed file extensions for additional files (*.rdoc). For use with JRuby 1.7.3, and bundler 3.0.4.

Internally I've fixed: Import nested modules/ packages, Conversion reference Py_IncRef, interpreter real name target instead of library (as https://github.com/steeve/rupy does); Added tests for optional named args functions (rspec and python function).

PS. I require some python native packages in my rails environment, to completed the bridge for my needs I've fixed/ added the above (some other fixes might follow).

raineszm commented 11 years ago

Looks like useful stuff. Hoe should already generate a gemspec file. Is there a particular reason to favor a handwritten gemspec?

dblommesteijn commented 11 years ago

About the spec, I've used the rake task (the Hoe way). The advantage is that you can use git repositories directly with bundler http://gembundler.com/v1.3/git.html, that way developers using it can use the latest commit without waiting for the tagged release.

dblommesteijn commented 11 years ago

I could push a separate branch for gemspec stuff, and the general fixes onto master. What do you think is the best approach here?