I should have create a feature branch for the first PR also, so we didn’t have the mixed log of both in here. But since I didn’t want to lose our conversation for the previous PR, I think the best solution is to I’ll keep it that way or if you prefer I can add those commit into master and to keep our first PR containing both Issue fixes
Everything should work as expected here. The only thing I’m not sure is the user friendly version of the label. I’ve done some research and most color blindness type seems to have couple of color problem. We can discuss that together to find the best solution for everyone.
I should have create a feature branch for the first PR also, so we didn’t have the mixed log of both in here. But since I didn’t want to lose our conversation for the previous PR, I think the best solution is to I’ll keep it that way or if you prefer I can add those commit into master and to keep our first PR containing both Issue fixes
Everything should work as expected here. The only thing I’m not sure is the user friendly version of the label. I’ve done some research and most color blindness type seems to have couple of color problem. We can discuss that together to find the best solution for everyone.