Closed flying-sheep closed 8 years ago
Ha, interesting, I don't get that, looks like I need to resort to publishing the compiled module
@flying-sheep kk, I'm shipping it as 'compiled' now and published it to npm, you should be able to install it via npm install decafjs
let me know if that solved the issue for you as I couldn't reproduce it :)
hmm, the npm version misses parts though:
e.g. this is missing from the code:
if (type === 'Literal') {
return mapLiteral(node, meta);
} else if (type === 'Range') {
return mapRange(node, meta);
} else if (type === 'Bool') {
return mapBoolean(node, meta);
} else if (type === 'Arr' && meta.left === true) {
return mapArrayPattern(node.base, meta);
} else if (type === 'Arr') {
return mapArrayExpression(node.base, meta);
} else if (type === 'Obj') {
return mapObjectExpression(node, meta);
} else if (type === 'Parens') {
return _astTypes.builders.sequenceExpression(node.base.body.expressions.map(function (expr) {
return mapExpression(expr, meta);
}));
}
The npm version will just contain the compiled version now but nothing should be missing really
Julian Krispel-Samsel rainforestqa.com goodafternoon.co
On Jan 25, 2016, at 21:13, Philipp A. notifications@github.com wrote:
hmm, the npm version misses parts though:
e.g. this is missing from the code:
if (type === 'Literal') { return mapLiteral(node, meta); } else if (type === 'Range') { return mapRange(node, meta); } else if (type === 'Bool') { return mapBoolean(node, meta); } else if (type === 'Arr' && meta.left === true) { return mapArrayPattern(node.base, meta); } else if (type === 'Arr') { return mapArrayExpression(node.base, meta); } else if (type === 'Obj') { return mapObjectExpression(node, meta); } else if (type === 'Parens') { return _astTypes.builders.sequenceExpression(node.base.body.expressions.map(function (expr) { return mapExpression(expr, meta); })); } — Reply to this email directly or view it on GitHub.
But it does. Look at the if/else tree: the npm version misses 2 branches
oh shit, thanks.
Fixed now, @flying-sheep
haha, np.
btw: what was wrong: did you simply have an old revision checked out when doing npm publish
?
@flying-sheep it was a typo in the npm hook. prebublish
:D, hence when publishing it didn't actually rebuild and used an outdated version...
aah noice :laughing:
console output
tail of debug log: