rainforestapp / fourchette

DEPRECATED - Your new best friend for isolated testing environments on Heroku.
MIT License
194 stars 23 forks source link

Pull code directly from GitHub #41

Closed markpundsack closed 9 years ago

markpundsack commented 10 years ago

It looks like fourchette currently pulls down the GitHub repo and then uploads it to the Heroku Build API, but the build API supports grabbing the tarball directly from GitHub. For private repos, you could use GitHub's temporary authenticated archive link:

https://developer.github.com/v3/repos/contents/#get-archive-link

/cc @friism

friism commented 10 years ago

+1!

jipiboily commented 10 years ago

Sadly this doesn't support submodule, which is the reason why I did it that way. In fact, I started with the proposed way here, but submodules being a requirement for us (and other people), it just doesn't work.

Any idea on how to work around this other than the current way of doing?

friism commented 10 years ago
jipiboily commented 10 years ago

I know and I agree, but it's still a thing.

friism commented 9 years ago

Hey @jipiboily, I just wanted to let you know that we have beta support for HTTP GIt. It uses the same API key authentication (not username/password) as the rest of the API. It also does git submodule restore.

You'd still have to pull changes from GitHub, but you don't have to do the submodule restore on your end, and you can also do incremental pushes to Heroku.

Let me know how it works if you give it a try.

jipiboily commented 9 years ago

Thanks for letting me know! I don't have much time these days, but when I have a little bit of time to work on Fourchette, I'll def look at it.

jipiboily commented 9 years ago

FYI, we just decided to deprecate Fourchette. You can (and probably should) use the Heroku review apps instead which was inspired by Fourchette.

https://devcenter.heroku.com/articles/github-integration-review-apps

Thanks!