Style clean-up and small refactors

rainforestapp / fourchette

DEPRECATED - Your new best friend for isolated testing environments on Heroku.

MIT License

194 stars 23 forks source link

Style clean-up and small refactors #47

Closed seanknox closed 9 years ago

seanknox commented 9 years ago

Hi there,

This is mostly a cosmetic PR and small refactoring to clean up styles according to the Ruby Style Guide. I find this much easier to read that what Hound suggests (single quoted strings, for example). Feedback welcome.

coveralls commented 9 years ago

Coverage increased (+0.03%) when pulling 615e72eda27d8ee2fadb1c3598fd4afdd222bb11 on seanknox:refactor_and_clean into 78ab379ec20ce226bbedea95d84f633665a1c461 on rainforestapp:master.

coveralls commented 9 years ago

Coverage increased (+0.03%) when pulling 615e72eda27d8ee2fadb1c3598fd4afdd222bb11 on seanknox:refactor_and_clean into 78ab379ec20ce226bbedea95d84f633665a1c461 on rainforestapp:master.

jipiboily commented 9 years ago

Thanks for this PR! Ignore the hound comments, I am going to disable it actually as it's more noise than anything.

I did a few comments here and there but overall looks good. Can you address them and refresh with master too? Thanks!

seanknox commented 9 years ago

@jipiboily Just updated the branch in response to most of your comments and ensured it was rebased off current master. Let me know what you think.

coveralls commented 9 years ago

Coverage decreased (-0.08%) when pulling f27c08432914da6688abc8711422d0d5e57e92d1 on seanknox:refactor_and_clean into 0ce8f0324f102bb82110582beae1d19d85dc4230 on rainforestapp:master.

jipiboily commented 9 years ago

Thanks! :+1: