Closed tokafish closed 9 years ago
Thanks for the PR!
The build is failing.
I added a couple of questions. I will need more time to test it. At first, it seems fine.
@scruti @thinkmorebetter: could you look at it and maybe try it on your apps? Would be awesome!
Thanks
No problem. It's still a work in progress, I was planning on fixing the tests, and using it a bit more with our app to iron out any issues (or example, our app needs 2X dynos, so I was hoping on getting that working).
@jipiboily I've fixed the specs - what do you think about merging this?
@wless1 Gave this branch a shot and ended up with the following error
I, [2015-04-29T19:40:18.580547 #18] INFO -- : Waiting for database #{to_name} to become available
RestClient::ResourceNotFound: 404 Resource Not Found: {"error":"not found"}
Not sure if I am doing something wrong, but the stack trace seems to suggest that it is a result wait_for_db
in pgbackups.rb
@wless1 sorry it's been so long. What's the status of this? Is this working for you?
FYI, we just decided to deprecate Fourchette. You can (and probably should) use the Heroku review apps instead which was inspired by Fourchette.
https://devcenter.heroku.com/articles/github-integration-review-apps
Thanks!
Closing, feel free to re-open if you think it's worth pursuing.
Coverage decreased (-3.32%) to 92.31% when pulling d3d621a7373c4f4d238b2569b37317aec49e93cc on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.