rainforestapp / fourchette

DEPRECATED - Your new best friend for isolated testing environments on Heroku.
MIT License
194 stars 23 forks source link

Updating fourchette to work with migrated Heroku pg:backups #57

Closed tokafish closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-3.32%) to 92.31% when pulling d3d621a7373c4f4d238b2569b37317aec49e93cc on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-4.39%) to 91.24% when pulling 5f530d0f7cd0f6a11663e98d155228e10f01ad27 on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

jipiboily commented 9 years ago

Thanks for the PR!

The build is failing.

I added a couple of questions. I will need more time to test it. At first, it seems fine.

@scruti @thinkmorebetter: could you look at it and maybe try it on your apps? Would be awesome!

Thanks

tokafish commented 9 years ago

No problem. It's still a work in progress, I was planning on fixing the tests, and using it a bit more with our app to iron out any issues (or example, our app needs 2X dynos, so I was hoping on getting that working).

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.15%) to 94.48% when pulling dbc3295e02afa5ecad273d0cf4175c7964805dba on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.15%) to 94.48% when pulling dbc3295e02afa5ecad273d0cf4175c7964805dba on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.15%) to 94.48% when pulling dbc3295e02afa5ecad273d0cf4175c7964805dba on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

tokafish commented 9 years ago

@jipiboily I've fixed the specs - what do you think about merging this?

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.05%) to 94.58% when pulling 44070a75dfacd710e5bcbcbb7e2b097ef4954c47 on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.05%) to 94.58% when pulling 44070a75dfacd710e5bcbcbb7e2b097ef4954c47 on carbonfive:master into 9ceaee2d1c322c619540d1698c71dac3948e1b9f on rainforestapp:master.

teldio-operations commented 9 years ago

@wless1 Gave this branch a shot and ended up with the following error

I, [2015-04-29T19:40:18.580547 #18]  INFO -- : Waiting for database #{to_name} to become available
RestClient::ResourceNotFound: 404 Resource Not Found: {"error":"not found"}

Not sure if I am doing something wrong, but the stack trace seems to suggest that it is a result wait_for_db in pgbackups.rb

jipiboily commented 9 years ago

@wless1 sorry it's been so long. What's the status of this? Is this working for you?

jipiboily commented 9 years ago

FYI, we just decided to deprecate Fourchette. You can (and probably should) use the Heroku review apps instead which was inspired by Fourchette.

https://devcenter.heroku.com/articles/github-integration-review-apps

Thanks!

jipiboily commented 9 years ago

Closing, feel free to re-open if you think it's worth pursuing.