search

raingart / Nova-YouTube-extension

Apache License 2.0
198 stars 9 forks source link

Control panel below the player #102

Closed MarkSpizu closed 10 months ago

MarkSpizu commented 10 months ago

"Control panel below the player" ON not working with videos from watch later for example.

Once the video is loading the player buttons disappear. Click to pause and you can only see a small progress bar.

Screenshot 2023-08-22 at 12-38-39 Happy Tree Friends Marathon (Part 3).png

MarkSpizu commented 10 months ago

The videos from personal playlists don't work with "Control panel below the player" ON.

If "Control panel below the player" is OFF everything works fine.

Script latest. Firefox latest, Violentmonkey 2.13.3.

raingart commented 10 months ago

Screenshot_5

Screenshot_6

MarkSpizu commented 10 months ago

Once I sign out it works. Maybe my account is probably in some beta test. Thanks for everything!

MarkSpizu commented 10 months ago

I just noticed (in your screenshots) that your player has straight corners. See my screenshot my player has little round corners (I never seen that before). So it is clear that my account is under beta test. Thanks!

MarkSpizu commented 10 months ago

This script fixed my bug

https://greasyfork.org/en/scripts/453802-youtube-non-rounded-design

raingart commented 10 months ago

the script you specified uses a lot of experimental flags. I think one of them cancels the new functionality.

Nova has a similar plugin called "Square avatars". But it cancels rounding through css, which is safer than flags

MarkSpizu commented 10 months ago

"Square avatars" it has no effect. After full screen/Exit full screen the player buttons disappear (as in my first screenshot).

With that script the player buttons are kept.

Screenshot 2023-08-22 at 17-28-34 Happy Tree Friends Marathon (Part 3).png

raingart commented 10 months ago

In a neighboring issue, one user mentioned that a rounded player happens if you are not logged into the site. It is strange that I did not notice this in incognito mode. But, those screenshots that I sent, I am also unlogged. This behavior is unclear to me.

Check this version if it fixed the bug?

https://gist.github.com/raingart/12695858bd13e356ac87350edf651193/

MarkSpizu commented 10 months ago

The videos were from my personal playlists. So, I was always logged in.

Yes, the new version fixed both issues:

  1. Player buttons not disappear after Full screen/Exit full screen.
  2. Player has straight corners.

Thanks a lot!

raingart commented 10 months ago

Great. I will close the issue when I release the release.