search

raingart / Nova-YouTube-extension

Apache License 2.0
199 stars 9 forks source link

Player Full-viewport disables scrolling #11

Closed Doosty closed 2 years ago

Doosty commented 2 years ago

Hi im trying to use "Player full-with (theater) mode - Full-viewport" however the youtube video page becomes impossible to scroll down. Using firefox, tampermonkey, latest Nova script.

Ps: Im currently using ResizeYoutubePlayerToWindowSize which works well and also moves the search header below the video, but it doesnt support mini player when scrolling and other goodies your script has.

raingart commented 2 years ago

Yes "pin player" plugin incompatible with ResizeYoutubePlayerToWindowSize

We both use the same techniques. Moreover, ResizeYoutubePlayerToWindowSize uses more aggressive methods by overlapping pin. I don't think it's possible to make them compatible. The only option compatible with ResizeYoutubePlayerToWindowSize is to replace the "pin plugin" css implementation with a picture-in-picture. But he is unstable. So far I haven't been able to bypass user-trusted events.

Scrolling does not work because only because it does not exist Full-viewport works. The non-scroll implementation is very simple and reliable.

As a workaround, I can recommend trying "Full-viewport" + two "section in popup" plugins for comments and video description.

Doosty commented 2 years ago

ImprovedTube BETA on Chrome can create pinned mini player + full window size, but it is bugged on Firefox unfortunately. These options:

Maybe it can give you some ideas, but i would be happy if you just enabled scrolling with full-window on your extension. Thank you.

raingart commented 2 years ago

try beta ver. It added a scroll when activating any (except "Default" item) mode.

Scrolling is activated when you hover over the player control panel. In order not to conflict with plugins that change the volume and speed of the video. But at the same time, the built-in volume control with the bear wheel stops working.

Additionally fixed item "Full-viewport exit if video ends/pause" which didn't work.

And the plugin itself is again renamed to "Theater mode".