raingart / Nova-YouTube-extension

Apache License 2.0
199 stars 9 forks source link

[Feature] Pin Header when Theater mode is set to full-viewport #132

Closed GoodTimesAhead closed 6 months ago

GoodTimesAhead commented 6 months ago

Full viewport is good but it would be nice to have the header always on instead of needing to mouse over. Can we have this as an option? Enhancer for Youtube used to have this they called it "Expand Video". Video would start below header and expand to full viewport height.

raingart commented 6 months ago

try offset mode

GoodTimesAhead commented 6 months ago

Offset doesn't do anything for me.

Here's the difference between offset and enhancer. The closest thing is full-viewport

https://i.imgur.com/lfVws8p.jpg

https://i.imgur.com/qjosHnp.jpg

GoodTimesAhead commented 6 months ago

If I add margin-top: 10rem to the div with id="columns" it seems to fix it but I don't know how sustainable this is.

GoodTimesAhead commented 6 months ago

That would just hide everything but the video. I added this and it does the trick

#columns { margin-top: 13em !important; }

raingart commented 6 months ago

agree. try this rev https://gist.github.com/raingart/2567b79fb3fc977d3096adb460e3ef3f

ytd-watch-flexy[theater]:not([fullscreen]) #columns {
    position: absolute;
    top: 100vh;
 }
GoodTimesAhead commented 6 months ago

agree. try this rev https://gist.github.com/raingart/2567b79fb3fc977d3096adb460e3ef3f

ytd-watch-flexy[theater]:not([fullscreen]) #columns {
    position: absolute;
    top: 100vh;
 }

Yeah this solves it and it's the most "correct" way to do it 👍