raingart / Nova-YouTube-extension

Apache License 2.0
212 stars 11 forks source link

[Bug] Load Related: Broken tag section #140

Closed zkisaboss closed 8 months ago

zkisaboss commented 8 months ago

When I re-open the related section the related tags are bugged. In the bugged example I cannot drag or click the arrow to select more tags, in the fixed example I can.

For some reason when I change the zoom level of my window it temorarily resloves the issue.

zkisaboss commented 8 months ago

Using inherit fixes all the padding issues: el.style.display = 'inherit'; <- el.style.display = 'unset';

These seem to break everything:

el.style.visibility = 'visible';
el.style.overflow = 'inherit';
el.style.height = 'inherit';

The bug remains with the related tags section.

zkisaboss commented 8 months ago

Also, I'm unsure if this is a bug or a feature, but collapsed video sections (after opening them in a video) don't stay collapseed when clicking on a new video. I have to reload the page.

zkisaboss commented 8 months ago

while your still here, there was a previous (unrelated) issue with padding when hiding buttons (download/share/etc.) and I found a ublock origin filters list that fixed this issue. lmk if you are interested in that filters list.

zkisaboss commented 8 months ago

On some (but not all) videos there is a gap between the like/dislike button and the other buttons.

Relevant Ublock Origin Filters:

! Video Metadata - share button
www.youtube.com##ytd-button-renderer:has(>a:has(> yt-formatted-string:has-text(Share)))
www.youtube.com##ytd-button-renderer:has(>yt-button-shape:has(> button[aria-label=Share]))
www.youtube.com##yt-button-view-model:has(>button-view-model> button[aria-label=Share])
! Video Metadata - download button
www.youtube.com##ytd-download-button-renderer
! Video Metadata - download worker
||www.youtube.com/s/player/*/player_ias.vflset/*/offline.js$script
! Video Metadata - thanks button
www.youtube.com##ytd-button-renderer:has(>a:has(> yt-formatted-string:has-text(Thanks)))
www.youtube.com##ytd-button-renderer:has(>yt-button-shape:has(> button[aria-label=Thanks]))
www.youtube.com##yt-button-view-model:has(>button-view-model> button[aria-label=Thanks])
! Video Metadata - thanks overflow menu
www.youtube.com##ytd-menu-service-item-renderer:has(>tp-yt-paper-item:has(>yt-formatted-string:has-text(Thanks)))
! Video Metadata - clip button
youtube.com##ytd-button-renderer:has(a:has(> yt-formatted-string:has-text(Clip)))
youtube.com##ytd-button-renderer:has(>yt-button-shape:has(> button[aria-label=Clip]))
youtube.com##yt-button-view-model:has(>button-view-model> button[aria-label=Clip])
! Video Metadata - clip overflow menu
www.youtube.com##ytd-menu-service-item-renderer:has(>tp-yt-paper-item:has(>yt-formatted-string:has-text(Clip)))
! Video Metadata - save button
!www.youtube.com##ytd-button-renderer:has(>yt-button-shape:has(> button:has-text(Save)):has(yt-icon))
!www.youtube.com##tp-yt-paper-item:has(yt-icon):has(yt-formatted-string:has-text(Save))
!www.youtube.com##yt-button-view-model:has(>button-view-model> button[aria-label=Save])
raingart commented 8 months ago

I looked at your adblock filters and they don't have a fix for the padding between buttons. the reason bug to be #flexible-item-buttons of the download button container

I use the same approach as your filter, but analyze icons. Because different localizations use different [aria-label]