search

raingart / Nova-YouTube-extension

Apache License 2.0
199 stars 9 forks source link

[Bug] volume hotkey wheel save #156

Closed zkisaboss closed 4 months ago

zkisaboss commented 4 months ago

The "Volume" setting in the PLAYER section is toggling my volume hotkey to "wheel" when I keep setting it to "none". Also, the default hotkey step is 10, which is silly because the default should be not changing it at all (YT's default is 5%).

raingart commented 4 months ago

error in configuration parameters. After updating added support keyboard other than Latin (English)

find the line volume_hotkey: {

after replace 

{ label: 'none' },

to

{ label: 'none', value: false },

if there is no value in a parameter should be ignored when saving. To reduce the data stored size. But the absence of value causes many triggers to fail. Correctly replace everything without value with false. But I don’t like it when the user changes a couple of parameters and all the other inactive ones are entered into the database.

raingart commented 4 months ago

Screenshot_1

raingart commented 4 months ago

why 10 was chosen instead of 5 - three reasons:

  1. This is a clear indication that the standard function has been successfully replaced.
  2. 10 steps sampling is enough for me. Since different videos have different volumes, the 5% accuracy is unnoticeable. I don't hear a difference of 50-55% or 95-100%. Locally in the system I can hear a difference of 2%, but not on YouTube.
  3. you need a number that is a multiple of 100. five are already taken and ten is the next closest

Essentially the reasons are technical

zkisaboss commented 4 months ago

Thanks, this appears to have fixed the issue for me.