raingart / Nova-YouTube-extension

Apache License 2.0
199 stars 9 forks source link

"Player sensitivity visibility range" not work #28

Closed cmhrky closed 1 year ago

cmhrky commented 1 year ago

Describe the bug

Whatever the "Pin player while scrolling > Player sensitivity visibility range" setting is set, it becomes active when the page is scrolled a little bit. My goal is for the player to activate when half of it is not visible but I failed.

raingart commented 1 year ago

When implementing, I tested it, but I also didn’t understand whether it works or not. I didn't see any difference when changing the value. I came to the conclusion that this is my misperception. The documentation can't be wrong.

Here is the documentation (threshold parameter)

My implementation

In the next release i will just hide this parameter

cmhrky commented 1 year ago

I wish Nova had this feature.