raingart / Nova-YouTube-extension

Apache License 2.0
213 stars 11 forks source link

[Bug] Stop play channel trailer and Default tab on channel page on a specific channel #50

Closed robertgarciakof closed 1 year ago

robertgarciakof commented 1 year ago

The options "Stop play channel Trailer and "Default tab on channel page" don't work on this particular channel, but in others channels it does: https://www.youtube.com/@MoreAlpha https://www.youtube.com/MoreAlpha

raingart commented 1 year ago

I noticed this on other channels. Some channels even before the introduction of the @ prefix had links in the form https://www.youtube.com/userName. ex. and I did not find a way to determine that we are now on the channel page.

The current pagetype definition function is based on the url and parsing it. Trying to define the page by internal htnl elements will break the plugin launcher

Also, some channels have crashes in YouTube itself. Here open the channel and click refresh page

I have looked at the implementation in other projects and they are all based on regex parsing of the page url

I won't fix it because I don't know how. If I were given a list of all existing YouTube page types I could use the exception method to determine that this is a channel now But since I myself use the limited capabilities of YouTube and not enough to figure out all a page type.

robertgarciakof commented 1 year ago

Ok, if it can't be done in a better way, it's better not to touch it

raingart commented 1 year ago

for pages like you gave an example, you can determine by the presence of uppercase letters. but this only partly solves the problem

// https://www.youtube.com/pencilmation - unsupported // https://www.youtube.com/rhino - unsupported

robertgarciakof commented 1 year ago

Curious, with these channels with capital letters it is true that they fail when they go without @ https://www.youtube.com/ProTradingSkills https://www.youtube.com/XboxToday https://www.youtube.com/ALBO

But at least they work with @ https://www.youtube.com/@ProTradingSkills https://www.youtube.com/@XboxAhoy https://www.youtube.com/@ALBO

raingart commented 1 year ago

Feature added in beta urlContainsUppercase(without unicode)

This is the maximum that can be done. My opinion is that even youtube itself does not work well without markers indicating that it is now a channel page, and not internal

And in 2 years to change /c/name and /@name indicates that they themselves don’t know what they are doing