search

raingart / Nova-YouTube-extension

Apache License 2.0
214 stars 11 forks source link

Userscript version screenshot hang #8

Closed fhoshino closed 2 years ago

fhoshino commented 2 years ago

Describe the bug

  1. Click on screenshot
  2. Screenshot box appear on top right conner
  3. CPU usage goes up

  4. Right clicking the screenshot thumb nail hangs the tab

    • Browser [Version 1.35.103 Chromium: 98.0.4758.102 (Official Build) (64-bit)]
    • Monkey (is use userscript) [violentmonkey 2.13.0]
    • Extension version [0.23.0]
raingart commented 2 years ago

You can make a video with the console open (F12 > console tab) or take a screenshot of the console. To see what's error. I don't even get a bug

Screenshot from 2022-02-18 16-58-49

fhoshino commented 2 years ago

I don't get errors from the console too, it's just hangs up the tab. brave_2022-02-18_23-03-22

raingart commented 2 years ago

i replaced console.debug with console.log reinstall it

And as I understand it, the screenshot thumbnail creates successfully. But it hangs when clicking on the generated mini image. Does the close button work?

raingart commented 2 years ago

error handling brave non-asynchronous call canvas.toDataURL() another call that was previously used. Asynchronous but smaller compact works correctly. canvas.toBlob(blob => location.href = URL.createObjectURL(blob));

for me on chromium v87 and 99 both work identically.

I will update the final test version now. Check it out and tell me how it is