raingart / Nova-YouTube-extension

Apache License 2.0
198 stars 9 forks source link

[Bug] Theatre Mode doesn't work #92

Closed Nuttar closed 1 year ago

Nuttar commented 1 year ago

Using Tampermonkey in both Brave and Firefox.

Theatre Mode doesn't seem to work, and also prevents scrolling entirely. I was using a script which only resized theatre mode to the full browser viewport, and then it broke entirely about an hour or so ago. So I ended up finding this script when looking for a fix. Though Nova's Theatre Mode is much less broken in comparison.

Also wondering if it were working as intended, does the full-viewport option allow scrolling down the page while the video stays the same size? and if scrolling to the top, will the Header be there making it hard to get it aligned properly again? if not, could that be an option? The previous script just moved the Header below the video instead, which worked great for me.

Nuttar commented 1 year ago

Looks like Zren has fixed their script #https://github.com/Zren/ResizeYoutubePlayerToWindowSize/issues/77#issuecomment-1612224069

I tried the CSS edit in StyleBot with the broken script enabled and it looks good. I don't know if you're interested in the script for proper integration, but I don't mind using both at once if they'll keep working well together.

raingart commented 1 year ago

found a problem. It turns out that YouTube changed the name of the elements inside and the plugin did not work at all to make it work, you need to replace the line PLAYER_CONTAINER_SELECTOR = 'ytd-watch-flexy[theater]:not([fullscreen]) #player-theater-container', on PLAYER_CONTAINER_SELECTOR = 'ytd-watch-flexy[theater]:not([fullscreen]) #player-container'

also omitted break; before case 'smart': line Turns out the plugin (Theater mode > Mode > full-viewport) was not working.

raingart commented 1 year ago

Header be there making...

it's only available when you select Mode > cinema. it becomes visible on hover

Sorry for not replying right away. Since I needed to understand how the plugin works, why it doesn't work now. And remember what he does. I don't use it and forgot

If I'm not mistaken, I once came across a script that seemed to do what you want. Ie there, on a key call, a search bar appeared and it seemed like you could scroll the page. If I find it I will send a link.

raingart commented 1 year ago

found it https://greasyfork.org/en/scripts/442089-pkga-youtube-theater-mode

raingart commented 1 year ago

I found another cool script

https://greasyfork.org/en/scripts/436667-better-youtube-theatre-mode

Nuttar commented 1 year ago

I like pkga's layout with chat, but it seems broken still. With Zren's updated Resize script working, i'll be using that for now. I guess i'll leave closing this upto you if/when you get to fixing up Novas theatre mode. Thanks for the help.

raingart commented 1 year ago

added new parameter offset - adaptation of this script

also added appearance of serchbar on hover (to full-viewport)

https://gist.github.com/raingart/2bb7d6e513a2827109e2de20e7eb9e26/raw/b05c0c098ce4df78d2c2646009ce12859f84c8bf/nova.user.js

if you test and there is no gap then I will close this issue

Nuttar commented 1 year ago

Scrolling the page doesn't work, even when toggling out of Theater. Changing [Hide scrollbar in watch page] doesn't seem to help (or in this case, changes nothing), and I have no other Tampermonkey scripts active.

raingart commented 1 year ago

Have you tried hovering your mouse over the player control panel from the bottom and scrolling over it?

Nuttar commented 1 year ago

Ah, I see. Unfortunately it only scrolls down once, and then scrolling up or down stops working.

raingart commented 1 year ago

I have been emailed several times by different users of Brave and Edge and they had errors that I didn't have on pure Chromium I believe that the changes in these browers are significant. I'll try to check sometime in brave how everything works. Most likely this is a bug specific to Brave.

raingart commented 1 year ago

Found the error reason. CSS hiding the scrollbar:

/* Hide scrollbars */
body { overflow: hidden; }

https://gist.github.com/raingart/2bb7d6e513a2827109e2de20e7eb9e26/raw/f00ee75de8ad900bfe4c454e19cb74639c2d8512/nova.user.js