search

raingart / Nova-YouTube-extension

Apache License 2.0
198 stars 9 forks source link

[Bug] #94

Closed MarkSpizu closed 1 year ago

MarkSpizu commented 1 year ago

Youtube pop-up appears

Your browser does not support css ":has()" operator. Approximately 5% of opportunities will be unavailable

Firefox, Violentmonkey.

Reverted back to [v0.43.0] no pop-up.

raingart commented 1 year ago
  1. click "ok" this should hide the popup.
  2. Or update your browser
  3. Or you can delete the line that is responsible for the popup( line 58-62)
raingart commented 1 year ago

one hundred clones of chromium support this operator. Firefox doesn't. Well I could do a workaround via js. But why do I need it? if i can do it through :has() For example the plugin Buttons > Hide items relies entirely on this operator

image

MarkSpizu commented 1 year ago

I deleted (line 58-62). no pop-up.

Anyway, the previous version [v0.43.0] was working fine. I didn't see a change log, I don't know if it was something important to be worth updating to [v0.43.1].

Thanks!

raingart commented 1 year ago

changelog https://github.com/raingart/Nova-YouTube-extension/releases/tag/v0.43.1

MarkSpizu commented 1 year ago

Good to know. Maybe in the next version you will find a way to make the script work in Firefox too. If not, I will keep deleting those lines.

Thanks!

raingart commented 1 year ago

don't you just have to click on the ok window:

Screenshot_8

and the message should no longer appear. It should store the state in localstorage:

Screenshot_1

I was reinsured in advance and decided to warn the user in such ways that part of the functionality will not work.

It may be worth hiding this warning as before. It seemed to me that 1 time to notify the user would be better than not saying anything

As I understand correctly, you do not save, and the notification appears constantly? You may be in incognito mode

MarkSpizu commented 1 year ago

Yes, is saved after OK. Normal mode. I don't use Private/Incognito. It's just that sometimes it appears again, I don't know what the reason is.

Could you do "hide warnings" in Options - OTHER?

raingart commented 1 year ago

I added an exception for embedded videos. Please check this version https://openuserjs.org/scripts/raingart/Nova_YouTube if the problem persists, I will remove this notification in the next release.

Also blocking cookies for the iframe can be the cause of the bug:

Screenshot_1

MarkSpizu commented 1 year ago

No change. For cookies I use this https://github.com/OhMyGuus/I-Still-Dont-Care-About-Cookies

raingart commented 1 year ago

then decided I'll remove the popup warning.