search

rainglow / jetbrains

320+ color themes for JetBrains IDEs including PHPStorm, Webstorm and more.
https://rainglow.io
MIT License
1.76k stars 74 forks source link

Fix colors on comment tag #2

Closed slovenianGooner closed 6 years ago

slovenianGooner commented 6 years ago

Fix colors to white from black on default doc comment tag.

daylerees commented 6 years ago

Hi @slovenianGooner thanks for this! I'll have to patch it back into the build process instead of merging it here or it will be overwritten. :) Can you show me a screenshot of what is effected if possible? Thanks!

slovenianGooner commented 6 years ago

Yeah, sure. Here it is. It is in PHPDoc comments in a class.

This is before: screen shot 2018-01-04 at 08 05 16

And this after: screen shot 2018-01-04 at 08 05 31

Of course, I selected #FFFFFF because it looks best to me, perhaps it is not aligned with the original theme, I just wanted to acknowledge the issue.

daylerees commented 6 years ago

Which theme is that mate? I don't think it should render like that. :)

daylerees commented 6 years ago

Here's my Storm for example. All themes should use a slightly lighter comment colour for the param:

http://dayle.io/0LA8zi

slovenianGooner commented 6 years ago

Sorry, forgot to mention it specifically but the screenshots are from codecourse, the fixes are for both codecourse and codecourse-contrast.

Hm, not sure, but I downloaded the .jar file and in the .xml the color is #000000.

daylerees commented 6 years ago

Woop, you're right it's broken in that release. 🤦‍♂️ I'll try to get a fix out.

daylerees commented 6 years ago

Solved this in 1.5.1 (you'll need the jar). Thanks for bringing this to my attention! :)