rainglow / jetbrains

320+ color themes for JetBrains IDEs including PHPStorm, Webstorm and more.
https://rainglow.io
MIT License
1.76k stars 74 forks source link

Light themes: Notifications are unreadable #24

Closed LunarWatcher closed 3 years ago

LunarWatcher commented 5 years ago

I'm aware this project hasn't been updated in a while, but I assume it gets any bug fixes if any show up.

image

The problem: The notification is made for a dark theme, but it's using a light theme. (These are called notifications in the color scheme editor anyways. I assume it applies to the actual notifications as well)

This happens on every single light theme. It's fine in the dark ones, because the text is readable, but in the light ones (the one in the pic is arbitrarily chosen), it shows up like that. Here is the problem, which I've found in every light theme I've tried. That value sets the notification color, and it is only a problem in the light themes. A quick search finds 326 results, all in xml files (not filtering light/dark/contrast), so it's set to that for them all.

It doesn't follow most of the themes (which isn't that big an issue), but on the light themes, it's unreadable.


For anyone using these themes, this can be temporarily fixed by going to Settings | Editor | Color Schemes | General | Editor | Notification background. But it would be optimal for it to be fixed in the schemes themselves rather than manually setting it for the active theme.