Use type property for themes

rainglow / vscode

320+ color themes for Visual Studio Code.

https://rainglow.io

MIT License

1.3k stars 54 forks source link

Use type property for themes #1

Closed usernamehw closed 6 years ago

usernamehw commented 6 years ago

All your themes default to dark. It affects many colors for elements.

"type": "light" | "dark"

In addition from 1.19 themes grouped in theme picker (dark | light | high contrast): theme-picker

daylerees commented 6 years ago

Ah interesting! Is that an early release build? I'm on the latest and it seems to be 1.18.x. I'll have a play with this! Should be an easy fix. Thanks for helping! ❤️

usernamehw commented 6 years ago

Yep, Insiders build.

daylerees commented 6 years ago

Thanks for the tip @usernamehw! :) I've updated the themes with the light/dark in the 1.0.1 release I've pushed to the marketplace.