search

rainglow / vscode

320+ color themes for Visual Studio Code.
https://rainglow.io
MIT License
1.3k stars 54 forks source link

String selector leaks through template literal #3

Closed usernamehw closed 6 years ago

usernamehw commented 6 years ago

There is a known bug which affects at least javascript & typescript: Items without selector inherit string color:

   [1,2,3].title;
`${[1,2,3].title}`

leakingcolor

There is 1 easy fix though: add to "tokenColors":

{
    "scope": "meta.template.expression",
    "settings": {
        "foreground": "#aec2e0"
    }
}

It was example for the legacy theme. This color should be the same as "editor.foreground" of the same theme.

If you want I can create a PR to fix this.

daylerees commented 6 years ago

Thanks again mate! I'll tackle this one tonight. Shouldn't be a problem. :)

daylerees commented 6 years ago

Have fixed this in 1.0.3, thanks once again! :)