search

rainlab / location-plugin

Adds location based features, such as Country and State.
Other
21 stars 44 forks source link

ip2c not working... #102

Closed snipiba closed 1 year ago

snipiba commented 1 year ago

If you can, replace ip2c.org with https://api.country.is/{$ip} instead

daftspunk commented 1 year ago

LGTM!

snipiba commented 1 year ago

LGTM! are u sure? https://github.com/rainlab/location-plugin/blob/109744be8d49d004488afd26467873a3feab0f45/models/Country.php#L99

call to HTTP protocol? i know, is inside as a server request, but also... it can be https (if you wish to use ip2c.org) https://ip2c.org/?ip=...

daftspunk commented 1 year ago

What you have suggested looks good. Make a pull request.

snipiba commented 1 year ago

What you have suggested looks good. Make a pull request.

i was not sure, if you mean, that LGTM as a is working on your side, or accepted as solution ;) i will fork and send PR