search

rainlake / homebridge-platform-lightify

MIT License
13 stars 5 forks source link

RGB Color setting #17

Closed drjamiwe closed 5 years ago

drjamiwe commented 5 years ago

Hi! Sadly yours is the only partially working Lightify plugin for the Homebridge but sadly it won't change the color of my PAR16 RGBW.

This plugin will let you change the colors, but lacks a few features and is completely unstable.

https://github.com/chris1705/homebridge-lightify

Is there any chance of including the RGB compatibility for the PAR16 RGBW Lamps? Thanks in advance!

devenbj commented 5 years ago

Found a few code changes that improved color changing for me. Both in: index.js

Change: this.service.getCharacteristic(Characteristic.Saturation).value = hsv.h * 100;

To: this.service.getCharacteristic(Characteristic.Saturation).value = hsv.s * 100;

Change: c = device.blue;

To: zone.blue = device.blue;

These changes require a restart to your homebridge.

mman commented 5 years ago

Just played with the plugin, these are obvious and correct changes. @rainlake Shall I create a pull request for you to merge?

rainlake commented 5 years ago

Awesome, thanks

On Sun, Apr 14, 2019 at 6:48 AM Martin Man notifications@github.com wrote:

Just played with the plugin, these are obvious and correct changes. @rainlake https://github.com/rainlake Shall I create a pull request for you to merge?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/rainlake/homebridge-platform-lightify/issues/17#issuecomment-482946984, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYg3SM4ndK1O3re8QZCokyLDLVN4d9Wks5vgwdogaJpZM4Yv4Sj .