search

rainlake / homebridge-platform-myq

19 stars 6 forks source link

Q: why the use of `moment(...)` when calling `this.log(...)` #5

Closed mrose17 closed 7 years ago

mrose17 commented 7 years ago

it seems redundant given that the homebridge Logger puts out a timestamp at the beginning of entry entry. if the timestamp format isn't desirable (and i agree it isn't), wouldn't it be better to submit a PR that lets the user specify the timestamp format in "config.json" ?

just a thought.

rainlake commented 7 years ago

Homebridge added time stamp not long ago. That's why you see duplicate time stamp there. I think we can remove it now.

On Monday, September 19, 2016, Marshall T. Rose notifications@github.com wrote:

it seems redundant given that the homebridge Logger puts out a timestamp at the beginning of entry entry. if the timestamp format isn't desirable (and i agree it isn't), wouldn't it be better to submit a PR that lets the user specify the timestamp format in "config.json" ?

just a thought.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rainlake/homebridge-platform-myq/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYg3dV1m5joQwP5KidMe5NbU7FD0R6Aks5qr0VPgaJpZM4KBKVJ .

mrose17 commented 7 years ago

great, thank you!

rainlake commented 7 years ago

fixed in 0.1.5