search

rainman74 / NPPTextFX2

TextFX2 is a Notepad++ plugin which performs a variety of common conversions on selected text.
GNU General Public License v3.0
128 stars 13 forks source link

"Unwrap" function still crashes Notepad++ #1

Closed pryrt closed 2 years ago

pryrt commented 2 years ago

As I explained in the Community Forum, the TextFX "unwrap" function crashes Notepad++ v8.4-and-newer because the plugin's code uses an out-of-date interface. This NPPTextFX2 plugin did not fix that problem, so it still crashes Notepad++ v8.4-and-newer.

rainman74 commented 2 years ago

As I explained in the Community Forum, the TextFX "unwrap" function crashes Notepad++ v8.4-and-newer because the plugin's code uses an out-of-date interface. This NPPTextFX2 plugin did not fix that problem, so it still crashes Notepad++ v8.4-and-newer.

Yes, I can confirm that. I will remove the unwrap function.

Are there any other problems?

pryrt commented 2 years ago

I am not actually a TextFX user, so I haven't tested all the functions. I would highly recommend that you go through every function and make sure it works before the next version.

Also, I would probably recommend trying to fix the issues, rather than just disabling the features, because if you have to disable too many of people's favorite TextFX features, they won't bother using your plugin.

rainman74 commented 2 years ago

I am not actually a TextFX user, so I haven't tested all the functions. I would highly recommend that you go through every function and make sure it works before the next version.

Also, I would probably recommend trying to fix the issues, rather than just disabling the features, because if you have to disable too many of people's favorite TextFX features, they won't bother using your plugin.

Thank you very much for your comment. I have removed the unwrap function for now in v0.31.

I will have a look at the code when I have time. For now, I just want to make the plugin error-free and executable again with the current Notepad++ version.