search

rainman74 / NPPTextFX2

TextFX2 is a Notepad++ plugin which performs a variety of common conversions on selected text.
GNU General Public License v3.0
121 stars 10 forks source link

Broken functionality #2

Closed pryrt closed 1 year ago

pryrt commented 1 year ago

Many of the TextFX Characters (including Swap Quotes, Escape , Unescape , and Case converts (non-exhaustive list)) drop the final character of the selection when it replaces.

This is due to the change in Scintilla 5.1.5, described here, which means that every call in your plugin to SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE will have to be fixed, because they will be off-by-one-byte compared to the existing code.

pryrt commented 1 year ago

see the details in @rpidaro's post here

rainman74 commented 1 year ago

Many of the TextFX Characters (including Swap Quotes, Escape , Unescape , and Case converts (non-exhaustive list)) drop the final character of the selection when it replaces.

This is due to the change in Scintilla 5.1.5, described here, which means that every call in your plugin to SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE will have to be fixed, because they will be off-by-one-byte compared to the existing code.

I'll take a look...

rainman74 commented 1 year ago

see the details in @rpidaro's post here

Wrong link?!

pryrt commented 1 year ago

https://community.notepad-plus-plus.org/post/78446

rainman74 commented 1 year ago

Many of the TextFX Characters (including Swap Quotes, Escape , Unescape , and Case converts (non-exhaustive list)) drop the final character of the selection when it replaces.

The problem is fixed with the 1.0 release. All functions should now be compatible again with the current Notepad++ and Scintilla 5.1.5+, hence the version upgrade to 1.0.