search

rainner / binance-watch

This application connects to the Binance.com public API to get live 24h price change data for all crypto trading pairs on their platform and allows you to set custom alerts or watch for price change in real time and get desktop notifications when something triggers your alerts or price watch settings.
MIT License
187 stars 80 forks source link

A few questions (Docker, Twitter, Production ENV) #29

Open GenericUK opened 3 years ago

GenericUK commented 3 years ago

Hi Rainner,

Great app.

I've managed to Dockerize it and get it running in DEV but not PROD starting src/app.js with node is throwing a SyntaxError: Unexpected identifier, on the import which I think is a babel issue probably due to what version of node I've used which was 10.24.1 as this was the highest supported by inotify that was available in the Node Docker hub. This brings me on to my first question, what version of Node are you using?

Next question is about the Twitter news function, amazing idea I was looking to code something myself that's how I came across you project on Github. Is this feature finished? I'm yet to see any Tweet data load.

Cheers Mark

rainner commented 3 years ago

Hey,

Node version 10.15.3 (npm 6.4.1) works for me, just did a quick npm build to confirm.

I built this a while ago, back then Twitter used to render their pages on the server, making it easy to fetch and scrape the html for an account. Now they moved on to client-side rendering, which broke the twitter news function. Might have to remove that from the app, or find another way to do it.