search

rainstormstudio / nerd-icons-dired

GNU General Public License v3.0
50 stars 11 forks source link

The command dired-goto-file not working. #10

Open Marie-Antoinette opened 1 year ago

Marie-Antoinette commented 1 year ago

Hi, After enable nerd-icons-dired the command dired-goto-file bound to 'j' key (in dired mode) doesn't work anymore, disable the nerd-icons-dired-mode will fix the issue. Config: (require 'nerd-icons-dired) (add-hook 'dired-mode-hook 'nerd-icons-dired-mode) (add-hook 'ibuffer-mode-hook #'nerd-icons-ibuffer-mode)

GNU Emacs 27.1 Tx.

RNAer commented 12 months ago

Similarly, dired-jump dose not work properly due to nerd-icons-dired.

GNU Emacs 29.0.92 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G9323)) of 2023-06-18

slayer152 commented 11 months ago

The problem seems to be that a TAB character is introduced between the icon and the filename while one of the functions called by dired-goto-file expects a leading SPC.

Replacing the \t in propertize arguments with a literal space in nerd-icons-dired--refresh makes dired-goto-file and dired-jump work properly for me

rainstormstudio commented 11 months ago

Thanks you @slayer152 for pointing this out! I just fixed it please check ec85df91642dc9718dfec288793c408f506afd78