nerd-icons-dired does not support `set-rectangular-region-anchor` + `kill-region` under `wdired` enabled Dired buffer

[stardiviner]

When I try to enable wdired on nerd-icons-dired minor mode enabled Dired buffer. I edit dired buffer will got error. file read-only. I hope this package can support "set-rectangular-region-anchor" in wdired-change-to-wdired-mode.

[stardiviner]

After I dive into source code:

• nerd-icons-dired implemented using text-property: https://github.com/rainstormstudio/nerd-icons-dired/blob/main/nerd-icons-dired.el#L84

• all-the-icons implemented using overlay: https://github.com/jtbm37/all-the-icons-dired/blob/master/all-the-icons-dired.el#L55

So this is the reason.

[rainstormstudio]

We changed to text-property a few days ago as overlay is not the proper way of using font icons like nerd-icons.

I'll take a look at wgrep and try to fix this.

[stardiviner]

Thanks.

[milanglacier]

Wdired mode in my computer works fine. What does using wgrep on dired buffer mean? I am on the commit c05ba4815d375d779644ca7ac215632fda75089c.

[stardiviner]

@milanglacier You're right, thanks for point out the right thing, I'm confused [C-c C-p] keybinding for wgrep and wdired. Now I updated issue title.

I recorded a video to reproduce my error when using wdired in Dired buffer with nerd-icons-dired buffer. You can see, in the video, I toggled wdired, I can edit and save the modified Dired buffer. Then I got error when I use set-rectangular-region-anchor to mark two place rectangluar region, then press [C-w] try to delete region selected, raised error buffer read-only.

recorded video

[rainstormstudio]

Thanks for the detailed video! I think it's because I set the icons to be readonly in the buffer. I'll look into this.

[stardiviner]

@rainstormstudio Any idea update about this problem?

[rainstormstudio]

I'll be moving back to overlays but before I do so I need to fix some bugs related to overlays.

[stardiviner]

The text-property can't be inserted without read-only property? Maybe Emacs-dev mailing list has some idea?

[rainstormstudio]

no it's dired who has read-only property already so I cannot insert the icons directly

[stardiviner]

I see, thanks for explaination.

[stardiviner]

The issue is fixed, close now. Thanks @rainstormstudio