rainstormstudio / nerd-icons.el

GNU General Public License v3.0
206 stars 22 forks source link

Add a public require for nerd-icons-data #19

Closed mohkale closed 1 year ago

mohkale commented 1 year ago

Hi.

I maintain all-the-icons-nerd-fonts. All this package really does is replace some all-the-icons config options to use nerd-fonts and allow you to call all-the-icons-insert-nerd-fa instead of all-the-icons-insert-fa for example. It basically integrates nerdfonts loosely into all-the-icons. Currently it isn't on melpa because I depend on icon definitions from another package twlz0ne/nerd-fonts.el and it isn't on MELPA. You've done a great job implementing an all-the-icons like interface for nerd-fonts and also updating the data definitions for nerd-fonts. I'd like to swap the package I use to source nerd-icons data to this one. All I need is to require the various nerd-icons-data-iec-* requires but the way it's currently setup you have to require all of this package just to access the definitions.

Please move the following block from nerd-icons.el to a new nerd-icons-data.el file so it can be used independent of the rest of this package.

(require 'nerd-icons-data-iec-power-symbols "./data/nerd-icons-data-iec-power-symbols")
(require 'nerd-icons-data-pomicons "./data/nerd-icons-data-pomicons")
(require 'nerd-icons-data-octicons "./data/nerd-icons-data-octicons")
(require 'nerd-icons-data-powerline "./data/nerd-icons-data-powerline")
(require 'nerd-icons-data-font-awesome "./data/nerd-icons-data-font-awesome")
(require 'nerd-icons-data-weather-icons "./data/nerd-icons-data-weather-icons")
(require 'nerd-icons-data-seti-ui-custom "./data/nerd-icons-data-seti-ui-custom")
(require 'nerd-icons-data-devicons "./data/nerd-icons-data-devicons")
(require 'nerd-icons-data-codicons "./data/nerd-icons-data-codicons")
(require 'nerd-icons-data-font-logos "./data/nerd-icons-data-font-logos")
(require 'nerd-icons-data-material-design "./data/nerd-icons-data-material-design")
rainstormstudio commented 1 year ago

This makes sense. I just added to nerd-icons-data.el