search

rainstormstudio / nerd-icons.el

GNU General Public License v3.0
206 stars 22 forks source link

Can we set some icon for ledger mode files ? #45

Closed justinjk007 closed 10 months ago

justinjk007 commented 10 months ago

I like to name my ledger files *.ledger , it would be nice to have some kinda icon for these files.

I know a lot people like to name them as *.dat too.

Here are some suggestions I come up with

nf-md-piggy_bank_outline

nf-md-file_table_outline

nf-md-file_table

seagle0128 commented 10 months ago

PRs are welcome 😄

justinjk007 commented 10 months ago

I opened a PR. Screenshot 2023-08-10 at 5 54 51 PM

Slightly unrelated, I noticed org-mode icon seems to be defined twice.

justinjk007 commented 10 months ago

~I should say I have never really done much development with elisp and couldn't workout how to test my change. It was so small I thought it should be ok.~ ~Some guidance there should be great. I tried eval-defun on that block and it didn't work.~

Never mind, I figured out I should be editing the list for files instead of modes. And amended my change. It's working now 🎉

Screenshot 2023-08-10 at 6 31 53 PM

seagle0128 commented 10 months ago

Slightly unrelated, I noticed org-mode icon seems to be defined twice.

I've deleted it in 8f0d9a3.