search

rainstormstudio / nerd-icons.el

GNU General Public License v3.0
206 stars 22 forks source link

`nf-dev-git` is buggy, maybe use default to `nf-seti-git` instead? (extension-icon-alist) #61

Closed ed9w2in6 closed 8 months ago

ed9w2in6 commented 8 months ago

Apparently the nf-dev-git icon of nerd-icons-devicon does not occupy 2 space currently. Only tested for VictorMono Nerd Font, and JetBrainsMono Nerd Font. The "git" "gitattributes" "gitignore" "gitmodules" are set to nf-dev-git in nerd-icons-extension-icon-alist currently. Which is not visually pleasing:

image

Compare this with nf-md-git:

image

nf-seti-git:

image

Currently I hacked it as such:

  (dolist (entry
           '(("git" nerd-icons-mdicon "nf-md-git" :face nerd-icons-lred)
             ("gitattributes" nerd-icons-mdicon "nf-md-git" :face nerd-icons-lred)
             ("gitignore" nerd-icons-mdicon "nf-md-git" :face nerd-icons-lred)
             ("gitmodules" nerd-icons-mdicon "nf-md-git" :face nerd-icons-lred)))
    (setf (alist-get (car entry) nerd-icons-extension-icon-alist
                     nil
                     nil
                     #'string=)
          (cdr entry)))

I saw a few issues with nf-md-* on windows so maybe default to nf-seti-git would be better? Or are there any specific reason to use nf-dev-git?

That being said this is potentially an error on nerd font side. I think they should all do ligature with a following space.