rainstormstudio / nerd-icons.el

GNU General Public License v3.0
206 stars 22 forks source link

recommendation: put `nerd-icons-dired` and `nerd-icons-completion` in this repo #8

Open milanglacier opened 1 year ago

milanglacier commented 1 year ago

minibuffer completion and dired are emacs builtin features. I see no reasons why we don't want to put those two extensions into this repo. They can be separated files, but including them in this repo makes totally sense.

It's like consult has included many extensions like consult-buffer, consult-ripgrep stuffs in the consult repo.

rainstormstudio commented 1 year ago

Actually this makes sense. I'll consider this. :)

milanglacier commented 1 year ago

Pros for this consideration:

since this is a new project, we want this project gain popularity as quick as possible. Putting essential features into separate repos is definitely not a good decision since I can bet 99% of users want to display icons in minibuffer and dired and they need to visit multiple repos and install many packages for one thing.

seagle0128 commented 1 year ago

Also for ibuffer? It's here currently, and already been released to melpa.

I don't think it's a big problem, whatever they are merged into one repo. Same situation for all-the-icons. It's just a core, and other packages are extensions.

jcs090218 commented 1 year ago

I've also created a simple plugin for buffer-menu, see jcs-elpa/nerd-icons-buffer-menu. :D

Thaodan commented 7 months ago

Also for ibuffer? It's here currently, and already been released to melpa.

I don't think it's a big problem, whatever they are merged into one repo. Same situation for all-the-icons. It's just a core, and other packages are extensions.

It seems silly to install a new package for each tiny feature where the Readme plus Cask is about the same size as the package itself.

hab25 commented 1 month ago

Counter argument: this would make it harder (impossible?) to communicate API breaking changes via git tags and semantic versioning at the level of granularity of those extensions.