raintank / grafana

Grafana - A Graphite & InfluxDB Dashboard and Graph Editor
http://grafana.org
Other
42 stars 4 forks source link

separate out raintank's metric package out of grafana into standalone #534

Closed Dieterbe closed 8 years ago

Dieterbe commented 8 years ago

pkg/metric

so that it's reusable to other apps and we don't need a fork of grafana.

woodsaj commented 8 years ago

@Dieterbe as you have been working on updating the metrics lib, can we address this too.

Dieterbe commented 8 years ago

the reason of pkg/metric's existence is it can neatly switch over between regular statsd and dogstatsd tags. but now that i've found a statsd client that looks like the highest performance - https://github.com/alexcesaro/statsd - and it also offers optional datadog and influx tags. there's no real need for this package at all anymore, and we can use this statsd client directly. ( and anyway we don't use DD anymore and presumably other people who would run litmus won't either. ) I will update everything in raintank-metric to use the new client directly, and then raintank/grafana and then we can just remove it this package.

Dieterbe commented 8 years ago

actually, an abstraction still makes sense for these reasons: