search

raintank / grafana

Grafana - A Graphite & InfluxDB Dashboard and Graph Editor
http://grafana.org
Other
42 stars 4 forks source link

add failing test for job assertStart #545

Closed Dieterbe closed 8 years ago

Dieterbe commented 8 years ago

I don't understand the code in #541 the quantizing logic adds the division remainder instead of what i would expect, subtracting it. I added a test that demonstrates the result I expected, I'ld like @woodsaj to add a commit that either fixes the test and its comments, or the logic, whichever is more appropriate, and then we can merge this branch.

woodsaj commented 8 years ago

Good catch @Dieterbe. The logic for setting the startTime was copied from graphite-raintank, which was wrong. But because they were both wrong, things just worked.

Both have now been corrected.