search

raintank / raintank-collector

Raintank Remote Collector Agent
26 stars 4 forks source link

circleci and packaging refactoring #21

Closed splaspood closed 9 years ago

splaspood commented 9 years ago

Cleaned up / simplified circleci.yml, moved packaging to scripts in pkg/

Will require PACKAGECLOUD_REPO='raintank/unstable' to work going forward.

woodsaj commented 9 years ago

jwb, this is looking good. I dont see anywhere in the build process where build.sh is called to build the ./go-ping binary, (this will be changing ./raintank-probe with https://github.com/raintank/raintank-collector/pull/20)

@splaspood

splaspood commented 9 years ago

You are correct, I'll take a look.

ctdk commented 9 years ago

One question: the PACKAGECLOUD_REPO environment variable is a great idea, but it occurred to me that we'll probably want to be able to deploy different branches to different repos. Can we set env vars conditionally in circle.yml, or will we need to be more clever?

splaspood commented 9 years ago

What do you mean conditionally?

ctdk commented 9 years ago

Meaning like setting PACKAGECLOUD_REPO to different values depending on what branches you're pushing. As far as I can tell the environment variables are per-project rather than per-branch.