raintank / worldping-api

Worldping Backend Service
Other
25 stars 18 forks source link

Standardize order of Checks across endpoint screens #11

Closed woodsaj closed 8 years ago

woodsaj commented 8 years ago

Issue by mattttt Monday Jul 06, 2015 at 16:04 GMT Originally opened as https://github.com/raintank/grafana/issues/301


The current order on assorted screens:

Endpoint List: Ping, DNS, HTTP, HTTPS Endpoint Summary: Ping, DNS, HTTP, HTTPS Endpoint Config: DNS, Ping, HTTP, HTTPS

Several weeks ago, we charged endpoint config to list DNS first (OSI model driven), but did not update the other two pages accordingly.

@nopzor1200 Can you confirm that we'd like to keep DNS first, and I'll push those changes. Thx!

woodsaj commented 8 years ago

Comment by nopzor1200 Saturday Jul 18, 2015 at 05:59 GMT


Yes, DNS first I think is best. TBH while it should be consistent we're not representing the OSI model as much as I'd originally anticipated.

woodsaj commented 8 years ago

Comment by Dieterbe Saturday Jul 18, 2015 at 13:27 GMT


huh according to OSI http, https and ping are all layer 7 (application layer) protocols, whereas ping is icmp is layer 3 (network). so wouldn't it make more sense to make it ping, dns, http, https? am i missing something?

woodsaj commented 8 years ago

Comment by mattttt Monday Aug 17, 2015 at 20:38 GMT


@nopzor1200 What say you? I'd like to close this out.

woodsaj commented 8 years ago

Comment by nopzor1200 Sunday Feb 14, 2016 at 17:21 GMT


I think that technically dieter is correct. But, practically, the DNS check is the only thing that's validating resolution from the auth DNS servers. So, it's going to fail independent of the health of the entire endpoint. And, if it fails, it will cause ping|http/s to both too.

Therefore I think the order everywhere should be dns | ping | http/s

woodsaj commented 8 years ago

Comment by Dieterbe Sunday Feb 14, 2016 at 20:20 GMT


Sounds good to me

woodsaj commented 8 years ago

Comment by Dieterbe Monday Apr 04, 2016 at 14:01 GMT


on https://app.raintank.io/dashboard/db/worldping-home the order is still incorrectly ping dns http/s

woodsaj commented 8 years ago

moved to https://github.com/raintank/worldping-app/issues/55