alert-executor.num metric only updates properly with builtin alerting

raintank / worldping-api

Worldping Backend Service

Other

25 stars 18 forks source link

alert-executor.num metric only updates properly with builtin alerting #28

Closed woodsaj closed 8 years ago

woodsaj commented 8 years ago

Issue by Dieterbe Tuesday Oct 20, 2015 at 20:48 GMT Originally opened as https://github.com/raintank/grafana/issues/497

can be easily evidenced in dev stack by changing

-handler = amqp
+handler = builtin

and looking at alerting dashboard, which amqp's case the "num executors" stays at 0. quick glance at the code looks ok, both amqp and internal should be starting the right number of executors

woodsaj commented 8 years ago

fixed in latest code release. Though we dont run a pool of executors anymore and instead just run as many are needed to execute queries. There is no need artificially constrain concurrency, available resources (cpu) will do that for us.