raintank / worldping-app

Apache License 2.0
85 stars 23 forks source link

wire up Collector tag dashboards #20

Open woodsaj opened 8 years ago

woodsaj commented 8 years ago

Issue by nopzor1200 Monday May 11, 2015 at 06:14 GMT Originally opened as https://github.com/raintank/grafana/issues/82


The links to dashboards-by-Collector-tag are dead.

Please wire up multiselect links for the list of Collectors in that tag.

We might use existing endpoint dashboard or create another dashboard for this. Still thinking about it. Important thing is that we can link to dashboard?var-collector= but with the Tag values instead of an individual Collector, and leverage the template multiselect now in Grafana.

woodsaj commented 8 years ago

Comment by woodsaj Tuesday May 12, 2015 at 06:50 GMT


This is not really possible as the rt-endpoint-summary dashboard does not allow multiSelect for the 'endpoint' variable.

woodsaj commented 8 years ago

Comment by mattttt Wednesday May 13, 2015 at 14:43 GMT


Then we'll adjust the front-end to remove those dashboard links for the moment.

woodsaj commented 8 years ago

Comment by nopzor1200 Wednesday May 13, 2015 at 14:46 GMT


Sorry I typod this ticket. I meant Collector tags (ie. collector multivar). The endpoint dashboards have multivar enabled for Collectors. I'll correct the title/text

woodsaj commented 8 years ago

Comment by woodsaj Wednesday May 13, 2015 at 14:55 GMT


@nopzor1200, still not sure what you are after here. Whether you are coming from the collector list page or the endpoint list page, we dont have a dashboard that allows multiselect of both endpoint and collector.

If i want to show a dashboard listing/summarizing all endpoints in a particular tag, then i need to pass endpoint={site_a, site_b, site_c}&collector=All

If i want to show a dashboard listing/summarizing all collectors in a particular tag, then i need to pass endpoint=All&collector={collector1, collector2}

in both these cases a dashboard that supports multiselect for both endpoint and collector is needed, but no such dashboard currently exists except for: https://portal.raintank.io/dashboard/raintank/statusboard

woodsaj commented 8 years ago

Comment by nopzor1200 Wednesday May 13, 2015 at 15:15 GMT


Hey sorry for all the confusion. Let me repaste what I added to the base ticket:


We might use existing endpoint dashboard or create another dashboard for this. Still thinking about it. Important thing is that we can link to dashboard?var-collector= but with the Tag values instead of an individual Collector, and leverage the template multiselect now in Grafana.


If we use the existing endpoint dashboard I do understand we will need to enable multivar on endpoints which is currently disabled. In previous versions of the dashboard this was enabled through the dynamic row functionality (repeat a row for each endpoint)

So I think we're on the same page in that we can do this provided we have a dashboard that supports endpoints=All and collectors={a,b,c}, right? I just wanted to be sure that we could correctly do this on the frontend, no matter which dashboard we end up going with (eg. endpoints, statusboard, collector, or whatever).

I meant to create such a dashboard right after I opened this ticket but got distracted

I'll be trying to play around with dashboards more today (including playing with #81), and trying to get others help in making these dashboards better.

(The whole point of this ticket was just to make sure that wiring up these dashboards to $dashboard could be easily wired up.)

woodsaj commented 8 years ago

Comment by woodsaj Wednesday May 13, 2015 at 15:29 GMT


gotcha.

I have already tested this and it works as expected.

I know Torkel has done a bunch of changes in upstream around multiSelect and repeat panels so i will merge that first. then add the dashboard links for tags.

woodsaj commented 8 years ago

Comment by bulletfactory Monday May 18, 2015 at 21:35 GMT


needs to be wired up with initial dashboard "Endpoint across Collectors"

woodsaj commented 8 years ago

Comment by mattttt Friday Jun 26, 2015 at 22:15 GMT


I believe this has been addressed in the dashboard Litmus Endpoint: Comparison, though it needs a better name.

Both tags being selected and functioning on dev-portal: screenshot 2015-06-26 17 14 04

woodsaj commented 8 years ago

Comment by nopzor1200 Monday Jun 29, 2015 at 22:27 GMT


So yes, we can use this dashboard (or any dashboard we choose to in the future).

Just talked to @woodsaj , he can get it using a glob for now until we add support to pass in a Tag.

woodsaj commented 8 years ago

Comment by nopzor1200 Monday Jun 29, 2015 at 22:30 GMT


We agreed to do a summary dashboard that showed a line for each collector but averaged across a group of endpoints. I will create such a dashboard and @woodsaj can easily link it up.

woodsaj commented 8 years ago

Comment by nopzor1200 Tuesday Jun 30, 2015 at 16:50 GMT


Step 1 - Come up with final final dashboard name - endpoint=all collector=glob Step 2 - Have awoods wire it up Step 3 - Investigate being able to pass Tags