search

rainwoodman / sharedmem

A different flavor of multiprocessing in Python
GNU General Public License v3.0
81 stars 9 forks source link

use documented method instead of hidden method to get ctype from Numpy 1.16 #16

Closed gpiantoni closed 5 years ago

gpiantoni commented 5 years ago

Thanks for sharing this great toolbox.

However, current implementation gives error when unpickling. My setup: python 3.7.3 numpy 1.16.2 sharedmem 0.3.5

gpiantoni commented 5 years ago

Build fails because the tests use NUMPY_VERSION=1.13 while the new method is available from numpy 1.16: https://github.com/numpy/numpy/pull/12769

rainwoodman commented 5 years ago

Thanks for the patch. We can probably support both versions of numpy. I will file a PR superceding yours.

gpiantoni commented 5 years ago

Thank you for the quick fix.