Open rainyl opened 1 week ago
So it works, but just need to rewrite nearly every API.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 87.98382%
with 208 lines
in your changes missing coverage. Please review.
Project coverage is 89.41%. Comparing base (
b16eb1b
) to head (a8b3732
). Report is 3 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
i just saw it, i will try to implement what i can and open a pr to this pr branch, can we spilt the modules so i handle some and you handle some to avoid we both implementing the same things?
also whats the easiest module i can follow as a reference since this pr has the alot of changes, so an easy module to follow will be the best option
i just saw it, i will try to implement what i can and open a pr to this pr branch, can we spilt the modules so i handle some and you handle some to avoid we both implementing the same things?
Sure, just create a new branch from async branch
also whats the easiest module i can follow as a reference since this pr has the alot of changes, so an easy module to follow will be the best option
For now I just implemented calib3d and imgcodecs, I think imgcodecs is the easiest, just several API in it, but remember to take a loot at core/types.h, in which many basic definitions inside it.
@abdelaziz-mahdy I have added async version of SVD, hope you are not doing the same module, may I ask which module are you working (or planning working) on?
Besides, if you finish some module, please open a PR to async branch.
I think dnn or objdetect, and if I faced any problem will let you know
For pr, deal will do so
callback
to existed functions or add new functions?new functions
, e.g.,CvStatus Mat_New_Async(MatCallback callback);