rainyl / opencv_dart

OpenCV bindings for Dart language and Flutter.
https://pub.dev/packages/opencv_dart
Apache License 2.0
78 stars 10 forks source link

Async Impl #101

Open rainyl opened 1 week ago

rainyl commented 1 week ago
rainyl commented 1 week ago

So it works, but just need to rewrite nearly every API.

https://github.com/rainyl/opencv_dart/blob/03ee7e659a294cf28031ad4b76e02b0724ca0b75/example/lib/main.dart#L46-L53

async_example

codecov-commenter commented 4 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.98382% with 208 lines in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (b16eb1b) to head (a8b3732). Report is 3 commits behind head on main.

Files Patch % Lines
lib/src/core/cv_vec.dart 16.66% 60 Missing :warning:
lib/src/dnn/dnn_async.dart 86.27% 28 Missing :warning:
lib/src/gapi/gcomputation.dart 28.57% 25 Missing :warning:
lib/src/imgproc/imgproc_async.dart 93.96% 23 Missing :warning:
lib/src/core/size.dart 58.00% 21 Missing :warning:
lib/src/core/termcriteria.dart 63.63% 8 Missing :warning:
lib/src/objdetect/objdetect_async.dart 97.72% 8 Missing :warning:
lib/src/gapi/gmat.dart 61.11% 7 Missing :warning:
lib/src/gapi/gscalar.dart 66.66% 7 Missing :warning:
lib/src/core/vec.dart 33.33% 4 Missing :warning:
... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #101 +/- ## ========================================== - Coverage 90.36% 89.41% -0.95% ========================================== Files 35 47 +12 Lines 5322 6677 +1355 ========================================== + Hits 4809 5970 +1161 - Misses 513 707 +194 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abdelaziz-mahdy commented 4 days ago

i just saw it, i will try to implement what i can and open a pr to this pr branch, can we spilt the modules so i handle some and you handle some to avoid we both implementing the same things?

also whats the easiest module i can follow as a reference since this pr has the alot of changes, so an easy module to follow will be the best option

rainyl commented 4 days ago

i just saw it, i will try to implement what i can and open a pr to this pr branch, can we spilt the modules so i handle some and you handle some to avoid we both implementing the same things?

Sure, just create a new branch from async branch

also whats the easiest module i can follow as a reference since this pr has the alot of changes, so an easy module to follow will be the best option

For now I just implemented calib3d and imgcodecs, I think imgcodecs is the easiest, just several API in it, but remember to take a loot at core/types.h, in which many basic definitions inside it.

rainyl commented 4 days ago

@abdelaziz-mahdy I have added async version of SVD, hope you are not doing the same module, may I ask which module are you working (or planning working) on?

Besides, if you finish some module, please open a PR to async branch.

abdelaziz-mahdy commented 4 days ago

I think dnn or objdetect, and if I faced any problem will let you know

For pr, deal will do so